Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Docker container for the Demo Application #11

Merged
merged 4 commits into from
Dec 24, 2021
Merged

Add Docker container for the Demo Application #11

merged 4 commits into from
Dec 24, 2021

Conversation

alexvasseur
Copy link
Contributor

adding Dockerfile and changing docker compose to run npm in Docker instead of local machine
minor edit to node.js to then link to redis (docker) instead of localhost

now can run simply with docker compose up

also added Redis Insight and changed Redis to standard image redismod

@mikhail-vl
Copy link
Contributor

@alexvasseur, Thank you for the PR. I will take a look and test the proposed changes.

@mikhail-vl mikhail-vl self-requested a review December 21, 2021 22:11
@mikhail-vl mikhail-vl added the enhancement New feature or request label Dec 21, 2021
@mikhail-vl mikhail-vl added this to the Version 2.1.0 milestone Dec 21, 2021
@mikhail-vl mikhail-vl changed the title npm in Docker, Redis Insight, redismod Add Docker container for the application Dec 24, 2021
@mikhail-vl mikhail-vl changed the title Add Docker container for the application Add Docker container for the Application Dec 24, 2021
@mikhail-vl mikhail-vl changed the title Add Docker container for the Application Add Docker container for the Demo Application Dec 24, 2021
mikhail-vl
mikhail-vl approved these changes Dec 24, 2021
View reviewed changes
Copy link
Contributor

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@mikhail-vl
Copy link
Contributor

@alexvasseur, thank you for the proposed changes.
I did some updates and removed RedisInsight v1. as I consider it EOL.

@mikhail-vl mikhail-vl merged commit b23b09e into RedisGrafana:master Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
Version 2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexvasseur @mikhail-vl